Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dep): address issue with caniuse-lite causing cdai build to fail #5816

Closed

Conversation

matthewgallo
Copy link
Member

Closes #5815

I noticed that the v1 release has failed for the past two weeks (we need to also stop releasing v1 weekly) and it appears it is because the build script for the cdai components was failing from a warning triggered from browserslist.

image

I ran the update command and confirmed that the build script for cdai passes locally.

What did you change?

yarn.lock

How did you test and verify your work?

Ran same build script via nx run @carbon/ibm-cloud-cognitive-cdai:build to double check that the failing build script now passes locally.

@davidmenendez
Copy link
Contributor

@matthewgallo @jlongshore seeing some tests failing here. what's the status?

@matthewgallo
Copy link
Member Author

This is blocked because the sub dependency that Mend lists as a vulnerability (ip) doesn't have a fix and is not maintained. jest-circus does have an alpha major version available but neither @elycheea and I can find any migration docs on it yet. I'll see if we can use it and convert this PR to a draft for now.

@matthewgallo matthewgallo marked this pull request as draft September 9, 2024 16:07
@matthewgallo
Copy link
Member Author

Closing in favor of #6176

@matthewgallo matthewgallo deleted the v1-build-fix branch October 7, 2024 14:25
@matthewgallo matthewgallo restored the v1-build-fix branch October 7, 2024 14:38
@matthewgallo matthewgallo reopened this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants